Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Updating stow version for GoogleAccessId issue #416

Merged
merged 1 commit into from
May 2, 2022
Merged

Updating stow version for GoogleAccessId issue #416

merged 1 commit into from
May 2, 2022

Conversation

pmahindrakar-oss
Copy link
Contributor

Signed-off-by: Prafulla Mahindrakar [email protected]

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@pmahindrakar-oss pmahindrakar-oss requested a review from yindia April 28, 2022 13:32
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #416 (a257d84) into master (9d9194c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   61.15%   61.15%           
=======================================
  Files         154      154           
  Lines       11093    11093           
=======================================
  Hits         6784     6784           
  Misses       3602     3602           
  Partials      707      707
Flag Coverage Δ
unittests 60.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9194c...a257d84. Read the comment docs.

EngHabu
EngHabu approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we verify on gcp before merging?

@pmahindrakar-oss
Copy link
Contributor Author

Currently failing on GCP and i am debugging the issue @EngHabu

Seems we need to give more permission here

flytectl register file  /Users/praful/flytesnacks/cookbook/core/_pb_output/*  -d development  -p flytesnacks --version v4 --logger.level 6
{"json":{"src":"viper.go:398"},"level":"debug","msg":"Config section [storage] updated. No update handler registered.","ts":"2022-05-02T19:03:02+05:30"}
{"json":{"src":"client.go:147"},"level":"warning","msg":"using insecureSkipVerify. Server's certificate chain and host name wont be verified. Caution : shouldn't be used for production usecases","ts":"2022-05-02T19:03:02+05:30"}
{"json":{"src":"client.go:183"},"level":"error","msg":"failed to initialize token source provider. Err: rpc error: code = Unimplemented desc = unknown service flyteidl.service.AuthMetadataService","ts":"2022-05-02T19:03:04+05:30"}
{"json":{"src":"client.go:188"},"level":"warning","msg":"Starting an unauthenticated client because: can't create authenticated channel without a TokenSourceProvider","ts":"2022-05-02T19:03:04+05:30"}
{"json":{"src":"client.go:147"},"level":"warning","msg":"using insecureSkipVerify. Server's certificate chain and host name wont be verified. Caution : shouldn't be used for production usecases","ts":"2022-05-02T19:03:04+05:30"}
{"json":{"src":"client.go:64"},"level":"info","msg":"Initialized Admin client","ts":"2022-05-02T19:03:04+05:30"}
{"json":{"src":"files.go:128"},"level":"info","msg":"Parsing file... Total(184)","ts":"2022-05-02T19:03:04+05:30"}
{"json":{"src":"files.go:141"},"level":"info","msg":"Fast Registration detected","ts":"2022-05-02T19:03:04+05:30"}
Error: failed to upload source code from [/Users/praful/flytesnacks/cookbook/core/_pb_output/fastdd16d76604fa162db1e9eeef3c236f13.tar.gz]. Error: failed to create an upload location. Error: rpc error: code = Unknown desc = failed to create a signed url. Error: unable to sign bytes: googleapi: Error 403: The caller does not have permission
{"json":{"src":"main.go:13"},"level":"error","msg":"failed to upload source code from [/Users/praful/flytesnacks/cookbook/core/_pb_output/fastdd16d76604fa162db1e9eeef3c236f13.tar.gz]. Error: failed to create an upload location. Error: rpc error: code = Unknown desc = failed to create a signed url. Error: unable to sign bytes: googleapi: Error 403: The caller does not have permission","ts":"2022-05-02T19:03:06+05:30"}

@pmahindrakar-oss
Copy link
Contributor Author

pmahindrakar-oss commented May 2, 2022 •
edited
Loading

@EngHabu please review this aswell flyteorg/flyte#2435
As adding new perm fixes the issue

@pmahindrakar-oss pmahindrakar-oss merged commit a08bbe8 into master May 2, 2022
@pmahindrakar-oss pmahindrakar-oss deleted the update-admin-stow branch May 2, 2022 14:18
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
@pmahindrakar-oss
Updating stow version for GoogleAccessId issue (#416)
acfb63b 
Signed-off-by: Prafulla Mahindrakar <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yindia yindia yindia approved these changes

@EngHabu EngHabu EngHabu approved these changes

@katrogan katrogan Awaiting requested review from katrogan katrogan is a code owner

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@anandswaminathan anandswaminathan Awaiting requested review from anandswaminathan

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmahindrakar-oss @EngHabu @yindia